Skip to content

adoptSocket: add optional ip parameter - #1267

Merged
uNetworkingAB merged 1 commit into
uNetworking:masterfrom
ValoChet:adoptSocket
Apr 22, 2026
Merged

adoptSocket: add optional ip parameter#1267
uNetworkingAB merged 1 commit into
uNetworking:masterfrom
ValoChet:adoptSocket

Conversation

@ValoChet

@ValoChet ValoChet commented Apr 2, 2026 •

Copy link
Copy Markdown
Contributor

Related to issue #1257.
Depends on uWS PR 1921.

Update adoptSocket() to accept an optional IP parameter.
Allowing the IP to be correctly set in the uSockets open handler for the adopted socket.

If someone accepts external FD, needs the IP on the request and uses the UWS_REMOTE_ADDRESS_USERSPACE cache, they have to pass the IP to adoptSocket().

for the ip to be correctly set in the open handler
@uNetworkingAB
uNetworkingAB merged commit a059fc6 into uNetworking:master Apr 22, 2026
1 check failed
@ValoChet
ValoChet deleted the adoptSocket branch April 25, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants