Skip to content

NativeString: update pool system - #1268

Closed
ValoChet wants to merge 1 commit into
uNetworking:masterfrom
ValoChet:NativeStringContext
Closed

NativeString: update pool system#1268
ValoChet wants to merge 1 commit into
uNetworking:masterfrom
ValoChet:NativeStringContext

Conversation

@ValoChet

@ValoChet ValoChet commented Apr 2, 2026 •

Copy link
Copy Markdown
Contributor

Resetting pool_offset in each function call is an issue, as we must ensure we don't perform sub-function calls that need it. And there is one: AppWrapper::readOptionsObject, called from addServerName(). They both use a different NativeStringContext, causing a buffer override.

With this, instead of resetting after every function call, it resets once all the allocated NativeStrings are freed. And we don’t need to build and pass a NativeStringContext every time.

@ValoChet ValoChet closed this Apr 9, 2026
@ValoChet
ValoChet deleted the NativeStringContext branch April 9, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant