Parallelised build, improved Github Actions (7 minutes build -> 3:20) - #1275
Parallelised build, improved Github Actions (7 minutes build -> 3:20)#1275Guthib-of-Dan wants to merge 4 commits into
Conversation
…odeJS headers, separated 'build-conf.h' from 'build.c', added .gitignore
|
And NO package managers, cache is just a compiled directory of git submodules. |
| - name: Setup Make fo Windows | ||
| if: matrix.os == 'windows-latest' | ||
| uses: ilammy/setup-nasm@v1.2.1 | ||
| run: choco install make |
There was a problem hiding this comment.
This is a supply chain attack surface.
There was a problem hiding this comment.
Not a static library though. But I will replace it then
|
This PR has many interesting parts. The speedup is mainly the cache of submodules? Problem is, and to be very blunt and economical. The gain (GitHub Actions build time) vs. the complexity (review time) is probably not worth it. Particularly since this change moves in a different direction from my own "vision". You add complexity to lower GitHub Actions build time, I strive to reduce complexity and move all platforms to the same compilation path (the recent move to use Clang++ on all platforms was such a massive improvement). I have an abandoned branch that uses even more common Clang++ flags and removes the build_windows for one common path and while I never finished it, that's the kind of direction the build files are moving towards. Also, this proejct lived for at least 5 years where build times were 50 minutes. And that was never a problem. So going from 50 -> 5 minutes while reducing complexity (that's right, the move was due to removing stuff), this change of yours cuts 3 minutes by introducing more complexity and more spinning wheels to care about. Further on, I have lived long enough to know from experience that build caches ALWAYS blow up in your face sooner or later. I cannot recollect how many times I have solved problems by clearing such caches. TLDR; it's certainly good and all, but this is not where the money is. Can this PR be merged? Certainly, it absolutely can. But I don't have the time or interest to review it. We can save it and return to it later (there are some raisins worth picking like the setbuf fix). |
|
I see the point, but my desire to make this library better in any possible way still persists. If you can’t review large modifications and those changes that add complexity, I will just split this into parts that are manageable and self-explanatory. |
|
So I am cancelling this pull request. I will PR its functionality step by step. I just understood that I had to make PRs only from separate branches and update "master" in fork only when PR gets approved. So now I have to reload the fork. I am still learning, ok? |
Main changes are