Skip to content

Made Utilities.h central header-file with includes of v8.h + uWS - #1279

Closed
Guthib-of-Dan wants to merge 1 commit into
uNetworking:masterfrom
ublitzjs:code-structure
Closed

Made Utilities.h central header-file with includes of v8.h + uWS#1279
Guthib-of-Dan wants to merge 1 commit into
uNetworking:masterfrom
ublitzjs:code-structure

Conversation

@Guthib-of-Dan

Copy link
Copy Markdown

Http3App.h headerfile in uWS doesn't have any macro checks to verify if it was already included, like Utilities.h. To address this I put Http3App.h include into Utilities.h. Considering its presence in every other file, I put repeated App.h there as well and removed unnecessary #include <v8.h> from every file, apart from Utilities.h.

This way Utilities.h provides codebase with LSP support, eliminating risk of re-including unprotected Http3App.h

@uNetworking uNetworking deleted a comment from Guthib-of-Dan Apr 21, 2026
@uNetworking uNetworking deleted a comment from Guthib-of-Dan Apr 21, 2026
@uNetworking uNetworking deleted a comment from Guthib-of-Dan Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant