fix NativeString encoding bug - #1281
Merged
Merged
Conversation
Contributor
|
This PR removes the ref counting. So the pool is never reset? |
Contributor
Author
|
It does not remove it, I moved it to the alloc() and free() function level. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the
String::ValueViewoptimization actually adds an encoding issue (#1280).Seems like the ValueView gives access to an ISO-8859-1 code points encoded string while we need a utf-8 encoded string.
So it was working for strings having same representation in both encoding but not for the others.
This PR removes de
String::ValueViewoptimization and only use theWriteUtf8()andWriteUtf8V2().We loose a bit of performance but not that much thanks to the pool system, it is still much faster than the old Utf8Value copy.
binary: 157k Req/Sec
Utf8Value: 152k Req/Sec
ValueView: 158k Req/Sec
WriteUtf8: 155k Req/Sec
WriteUtf8V2: 156k Req/Sec