docs: say what close() and end() do with messages already sent - #1306
Merged
uNetworkingAB merged 1 commit intoSep 13, 2026
Merged
Conversation
close() maps to the close() syscall, so anything still queued by send() is not delivered; end() delivers it and then sends the close message. The distinction was implied by 'forcefully' and 'gracefully' but never written, and reading close() as the graceful one costs a silent loss of the last message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following meteor/meteor#14746 (comment).
close()andend()differ in one way that the current wording leaves implicit: what happens to a message already handed tosend(). Measured on 20.66.0, sending one frame and shutting down in the same tick:socket.close()socket.end()Reading "Forcefully" and "Gracefully" as being only about the close frame, we used
close()after a finalsend()and lost that message silently. This adds the syscall mapping you described and names the consequence, so the next reader picksend()without measuring first.