Skip to content

Commit 3d3dd05

Browse files
Revert "Add HttpResponse.writeHeaders" (#1234)
* Initial plan * Revert "Add HttpResponse.writeHeaders" Co-authored-by: uNetworkingAB <110806833+uNetworkingAB@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: uNetworkingAB <110806833+uNetworkingAB@users.noreply.github.com>
1 parent 8982605 commit 3d3dd05

2 files changed

Lines changed: 0 additions & 48 deletions

File tree

‎docs/index.d.ts‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -155,10 +155,6 @@ export interface HttpResponse {
155155
* See writeStatus and corking.
156156
*/
157157
writeHeader(key: RecognizedString, value: RecognizedString) : HttpResponse;
158-
/** Writes all key/value pairs of the provided object as HTTP response headers.
159-
* See writeStatus and corking.
160-
*/
161-
writeHeaders(headers: Record<string, RecognizedString>) : HttpResponse;
162158
/** Enters or continues chunked encoding mode. Writes part of the response. End with zero length write. Returns true if no backpressure was added. */
163159
write(chunk: RecognizedString) : boolean;
164160
/** Ends this response by copying the contents of body. */

‎src/HttpResponseWrapper.h‎

Lines changed: 0 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -477,49 +477,6 @@ struct HttpResponseWrapper {
477477
}
478478
}
479479

480-
/* Takes object of key/value pairs. Returns this */
481-
template <int PROTOCOL>
482-
static void res_writeHeaders(const FunctionCallbackInfo<Value> &args) {
483-
Isolate *isolate = args.GetIsolate();
484-
auto *res = getHttpResponse<PROTOCOL>(args);
485-
if (res) {
486-
if (!args[0]->IsObject()) {
487-
args.GetReturnValue().Set(isolate->ThrowException(v8::Exception::TypeError(String::NewFromUtf8(isolate, "writeHeaders requires an object of key/value pairs.", NewStringType::kNormal).ToLocalChecked())));
488-
return;
489-
}
490-
491-
Local<Context> context = isolate->GetCurrentContext();
492-
Local<Object> headersObj = Local<Object>::Cast(args[0]);
493-
494-
Local<Array> propertyNames;
495-
if (!headersObj->GetOwnPropertyNames(context).ToLocal(&propertyNames)) {
496-
return;
497-
}
498-
499-
assumeCorked();
500-
501-
for (uint32_t i = 0; i < propertyNames->Length(); i++) {
502-
Local<Value> key;
503-
Local<Value> value;
504-
if (!propertyNames->Get(context, i).ToLocal(&key) || !headersObj->Get(context, key).ToLocal(&value)) {
505-
return;
506-
}
507-
508-
NativeString header(isolate, key);
509-
if (header.isInvalid(args)) {
510-
return;
511-
}
512-
NativeString headerValue(isolate, value);
513-
if (headerValue.isInvalid(args)) {
514-
return;
515-
}
516-
res->writeHeader(header.getString(), headerValue.getString());
517-
}
518-
519-
args.GetReturnValue().Set(args.This());
520-
}
521-
}
522-
523480
/* Takes function, returns this */
524481
template <int SSL>
525482
static void res_cork(const FunctionCallbackInfo<Value> &args) {
@@ -608,7 +565,6 @@ struct HttpResponseWrapper {
608565
resTemplateLocal->PrototypeTemplate()->Set(String::NewFromUtf8(isolate, "tryEnd", NewStringType::kNormal).ToLocalChecked(), FunctionTemplate::New(isolate, res_tryEnd<SSL>));
609566
resTemplateLocal->PrototypeTemplate()->Set(String::NewFromUtf8(isolate, "write", NewStringType::kNormal).ToLocalChecked(), FunctionTemplate::New(isolate, res_write<SSL>));
610567
resTemplateLocal->PrototypeTemplate()->Set(String::NewFromUtf8(isolate, "writeHeader", NewStringType::kNormal).ToLocalChecked(), FunctionTemplate::New(isolate, res_writeHeader<SSL>));
611-
resTemplateLocal->PrototypeTemplate()->Set(String::NewFromUtf8(isolate, "writeHeaders", NewStringType::kNormal).ToLocalChecked(), FunctionTemplate::New(isolate, res_writeHeaders<SSL>));
612568
resTemplateLocal->PrototypeTemplate()->Set(String::NewFromUtf8(isolate, "close", NewStringType::kNormal).ToLocalChecked(), FunctionTemplate::New(isolate, res_close<SSL>));
613569
resTemplateLocal->PrototypeTemplate()->Set(String::NewFromUtf8(isolate, "onWritable", NewStringType::kNormal).ToLocalChecked(), FunctionTemplate::New(isolate, res_onWritable<SSL>));
614570
resTemplateLocal->PrototypeTemplate()->Set(String::NewFromUtf8(isolate, "onAborted", NewStringType::kNormal).ToLocalChecked(), FunctionTemplate::New(isolate, res_onAborted<SSL>));

0 commit comments

Comments
 (0)