Skip to content

Commit b03dd9d

Browse files
Add HttpResponse.writeHeaders (#1227)
* Initial plan * Add HttpResponse.writeHeaders method Co-authored-by: uNetworkingAB <110806833+uNetworkingAB@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: uNetworkingAB <110806833+uNetworkingAB@users.noreply.github.com>
1 parent 7d83524 commit b03dd9d

2 files changed

Lines changed: 48 additions & 0 deletions

File tree

‎docs/index.d.ts‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,10 @@ export interface HttpResponse {
144144
* See writeStatus and corking.
145145
*/
146146
writeHeader(key: RecognizedString, value: RecognizedString) : HttpResponse;
147+
/** Writes all key/value pairs of the provided object as HTTP response headers.
148+
* See writeStatus and corking.
149+
*/
150+
writeHeaders(headers: Record<string, RecognizedString>) : HttpResponse;
147151
/** Enters or continues chunked encoding mode. Writes part of the response. End with zero length write. Returns true if no backpressure was added. */
148152
write(chunk: RecognizedString) : boolean;
149153
/** Ends this response by copying the contents of body. */

‎src/HttpResponseWrapper.h‎

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -453,6 +453,49 @@ struct HttpResponseWrapper {
453453
}
454454
}
455455

456+
/* Takes object of key/value pairs. Returns this */
457+
template <int PROTOCOL>
458+
static void res_writeHeaders(const FunctionCallbackInfo<Value> &args) {
459+
Isolate *isolate = args.GetIsolate();
460+
auto *res = getHttpResponse<PROTOCOL>(args);
461+
if (res) {
462+
if (!args[0]->IsObject()) {
463+
args.GetReturnValue().Set(isolate->ThrowException(v8::Exception::TypeError(String::NewFromUtf8(isolate, "writeHeaders requires an object of key/value pairs.", NewStringType::kNormal).ToLocalChecked())));
464+
return;
465+
}
466+
467+
Local<Context> context = isolate->GetCurrentContext();
468+
Local<Object> headersObj = Local<Object>::Cast(args[0]);
469+
470+
Local<Array> propertyNames;
471+
if (!headersObj->GetOwnPropertyNames(context).ToLocal(&propertyNames)) {
472+
return;
473+
}
474+
475+
assumeCorked();
476+
477+
for (uint32_t i = 0; i < propertyNames->Length(); i++) {
478+
Local<Value> key;
479+
Local<Value> value;
480+
if (!propertyNames->Get(context, i).ToLocal(&key) || !headersObj->Get(context, key).ToLocal(&value)) {
481+
return;
482+
}
483+
484+
NativeString header(isolate, key);
485+
if (header.isInvalid(args)) {
486+
return;
487+
}
488+
NativeString headerValue(isolate, value);
489+
if (headerValue.isInvalid(args)) {
490+
return;
491+
}
492+
res->writeHeader(header.getString(), headerValue.getString());
493+
}
494+
495+
args.GetReturnValue().Set(args.This());
496+
}
497+
}
498+
456499
/* Takes function, returns this */
457500
template <int SSL>
458501
static void res_cork(const FunctionCallbackInfo<Value> &args) {
@@ -541,6 +584,7 @@ struct HttpResponseWrapper {
541584
resTemplateLocal->PrototypeTemplate()->Set(String::NewFromUtf8(isolate, "tryEnd", NewStringType::kNormal).ToLocalChecked(), FunctionTemplate::New(isolate, res_tryEnd<SSL>));
542585
resTemplateLocal->PrototypeTemplate()->Set(String::NewFromUtf8(isolate, "write", NewStringType::kNormal).ToLocalChecked(), FunctionTemplate::New(isolate, res_write<SSL>));
543586
resTemplateLocal->PrototypeTemplate()->Set(String::NewFromUtf8(isolate, "writeHeader", NewStringType::kNormal).ToLocalChecked(), FunctionTemplate::New(isolate, res_writeHeader<SSL>));
587+
resTemplateLocal->PrototypeTemplate()->Set(String::NewFromUtf8(isolate, "writeHeaders", NewStringType::kNormal).ToLocalChecked(), FunctionTemplate::New(isolate, res_writeHeaders<SSL>));
544588
resTemplateLocal->PrototypeTemplate()->Set(String::NewFromUtf8(isolate, "close", NewStringType::kNormal).ToLocalChecked(), FunctionTemplate::New(isolate, res_close<SSL>));
545589
resTemplateLocal->PrototypeTemplate()->Set(String::NewFromUtf8(isolate, "onWritable", NewStringType::kNormal).ToLocalChecked(), FunctionTemplate::New(isolate, res_onWritable<SSL>));
546590
resTemplateLocal->PrototypeTemplate()->Set(String::NewFromUtf8(isolate, "onAborted", NewStringType::kNormal).ToLocalChecked(), FunctionTemplate::New(isolate, res_onAborted<SSL>));

0 commit comments

Comments
 (0)